Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typings): update types file #2425

Merged
merged 2 commits into from
Jul 28, 2020
Merged

fix(typings): update types file #2425

merged 2 commits into from
Jul 28, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 27, 2020 •
edited by WilcoFiers
Loading

Closes issue: #2316, #2317, #2378

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner July 27, 2020 23:01
@straker straker mentioned this pull request Jul 27, 2020
Closed
@straker straker merged commit 0aab922 into develop Jul 28, 2020
@straker straker deleted the typings branch July 28, 2020 16:34
@engelsdamien
Copy link

Why was restoreScroll removed from RunOptions ? I could not find a reference to it in the 4.0 release notes nor in the issues linked in this PR.

@engelsdamien
Copy link

found it, it was removed in #2388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@straker @engelsdamien @WilcoFiers