fix(aria/get-role-type): work with standards object #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
approved these changes
Jul 10, 2020
| return null; | ||
| } | ||
|
|
||
| return roleDef.type; |
There was a problem hiding this comment.
Previously, this would return null if there wasn't a truthy .type. Do we need to maintain consistently, or is the possibility of returning undefined here ok?
There was a problem hiding this comment.
Every role should have a type so it shouldn't be possible to return undefined or null. A role without a type should be treated as a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
get-role-typeto have a better happy path and return early rather than doing the&&and||checks.Part of #2108
Reviewer checks
Required fields, to be filled out by PR reviewer(s)