Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Allow impact to be null #2321

Merged
merged 1 commit into from
Jun 24, 2020
Merged

fix(types): Allow impact to be null #2321

merged 1 commit into from
Jun 24, 2020

Conversation

stephenmathieson
Copy link
Member

@stephenmathieson stephenmathieson commented Jun 24, 2020 •
edited by WilcoFiers
Loading

Closes #2313

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@stephenmathieson stephenmathieson requested a review from a team June 24, 2020 13:42
@stephenmathieson stephenmathieson requested a review from a team as a code owner June 24, 2020 13:42
@stephenmathieson stephenmathieson merged commit 757aacd into develop Jun 24, 2020
@stephenmathieson stephenmathieson deleted the impact-null branch June 24, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can impact be null?
2 participants
@stephenmathieson @WilcoFiers