fix: check invaildrole fails only when all roles are invalid
#2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invaildrole fails only when all roles are invalid
WilcoFiers
previously approved these changes
Mar 2, 2020
|
@WilcoFiers As I was working on a fix for something else, I pushed into this branch by mistake. I had to reset it, which dismissed the approval. Please do the needy. |
straker
previously requested changes
Mar 2, 2020
Co-Authored-By: Steven Lambert <steven.lambert@deque.com>
WilcoFiers
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invalidroleshould fail only when all roles on a given element are invalid.Closes issue:
invalidroleto fail when all given roles are invalid #2073Reviewer checks
Required fields, to be filled out by PR reviewer(s)