Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compute orientation lock from various transformation functions #1937

Merged
merged 6 commits into from
Dec 18, 2019
Merged

fix: compute orientation lock from various transformation functions #1937

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8ff44bd
fix: compute orientation lock from transformation functions that affe…
jeeyyy Dec 11, 2019
30c45b7
test: add more unit and integration tests
jeeyyy Dec 12, 2019
272d4b1
test: update transform with browser prefixes
jeeyyy Dec 12, 2019
96f7a82
refactor: based on code review
jeeyyy Dec 13, 2019
cf70d2e
fix: make angle calculation absolute to degree easily compare to clos…
jeeyyy Dec 16, 2019
738634c
chore: merge from develop
jeeyyy Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: update transform with browser prefixes
  • Loading branch information
@jeeyyy
jeeyyy committed Dec 12, 2019
commit 272d4b1c8979a469bfddf7eaf61ae7fe781ee87c
8 changes: 4 additions & 4 deletions test/checks/mobile/css-orientation-lock.js
View file
Original file line number Diff line number Diff line change
@@ -204,7 +204,7 @@ describe('css-orientation-lock tests', function() {
root: document,
sheet: getSheet(
// apply 0 on the z-axis (3rd parameter) does not apply given rotation on z-axis
'@media screen and (min-width: 1px) and (max-width: 3000px) and (orientation: landscape) { #mocha { transform: rotate3d(0,0,1,90deg) } }'
'@media screen and (min-width: 1px) and (max-width: 3000px) and (orientation: landscape) { #mocha { transform: rotate3d(0,0,1,90deg); -webkit-transform: rotate3d(0,0,1,90deg) } }'
)
}
]
@@ -219,7 +219,7 @@ describe('css-orientation-lock tests', function() {
shadowId: undefined,
root: document,
sheet: getSheet(
'@media screen and (min-width: 1px) and (max-width: 3000px) and (orientation: landscape) { #mocha { transform: rotate3d(0,0,1,1.5708rad) } }'
'@media screen and (min-width: 1px) and (max-width: 3000px) and (orientation: landscape) { #mocha { transform: rotate3d(0,0,1,1.5708rad); -webkit-transform: rotate3d(0,0,1,1.5708rad) } }'
)
}
]
@@ -235,7 +235,7 @@ describe('css-orientation-lock tests', function() {
root: document,
sheet: getSheet(
// this rotates by 90deg
'@media screen and (min-width: 1px) and (max-width: 3000px) and (orientation: landscape) { #mocha { transform:matrix(0.00,1.00,-1.00,0.00,0,0); } }'
'@media screen and (min-width: 1px) and (max-width: 3000px) and (orientation: landscape) { #mocha { transform:matrix(0.00,1.00,-1.00,0.00,0,0); -webkit-transform:matrix(0.00,1.00,-1.00,0.00,0,0); } }'
)
}
]
@@ -251,7 +251,7 @@ describe('css-orientation-lock tests', function() {
root: document,
sheet: getSheet(
// this rotates by 90deg
'@media screen and (min-width: 1px) and (max-width: 3000px) and (orientation: landscape) { #mocha { transform: matrix3d(0,-1,0.00,0,1.00,0,0.00,0,0,0,1,0,0,0,0,1); } }'
'@media screen and (min-width: 1px) and (max-width: 3000px) and (orientation: landscape) { #mocha { transform: matrix3d(0,-1,0.00,0,1.00,0,0.00,0,0,0,1,0,0,0,0,1); -webkit-transform: matrix3d(0,-1,0.00,0,1.00,0,0.00,0,0,0,1,0,0,0,0,1); } }'
)
}
]