-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ensures axe Pro api #1836
Conversation
9ac1b33
to
534aaac
Compare
534aaac
to
b0d19c4
Compare
Question: Most of these checks are just checking that the API exists, is a function, and returns the correct thing. Should these be unit tests in the respected files rather than an integration test all in one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't dig in too far here, but think the test names are very confusing.
b0d19c4
to
86b778e
Compare
better test names, removed console (tried to use Typscript'ish signature conventions)
This file should be marked for special review once it lands, the same way we protect manifest changes in the extension. Changes in this file only could represent a shift in the axe-core api that breaks axe Pro. For that reason, spreading these tests into their respective modules would make it harder to keep an "eye" on the api axe Pro requires to operate. |
86b778e
to
0e93973
Compare
removed all "isFunction" checks
@AutoSponge +1 on the decision to only test call signatures. We're testing those functions in depth elsewhere. I agree with the idea of adding you and/or Harris as code owner for these tests. |
df6866d
to
65f4a5c
Compare
Is there anything that needs to happen based on #1836 (comment)? |
@stephenmathieson I assume a code owner of axe-core will need to update the reviewer settings when this file lands. Should this PR include an update to |
I think this can land without a "codeowners" update and when @WilcoFiers's back, he can decide what to do moving forward. |
This adds tests that will help prevent breaking changes in axe-core that axe Pro depends on.
Closes issue: N/A (Q3 rock)
Reviewer checks
Required fields, to be filled out by PR reviewer(s)