fix(utils): Fix error in IE when getting scroll state on page with SVG elements #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th SVG elements. Closes #525
|
|
|
@WilcoFiers @straker Could you please take a look at this pull request? This issue is breaking my tests and blocking by project. |
| } | ||
| return scrolls.concat(getElmScrollRecursive(elm)); | ||
| }, []); | ||
| return Array.from(root.children || root.childNodes || []).reduce( |
There was a problem hiding this comment.
I'm late to the party, but it would be nice to see a "SVGs in IE don't have .children" (or alike) comment here. Otherwise a future developer may not know what this is for.
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any page in IE that has an SVG element, accessing
.childrenon an SVGElement when getting the scroll state would returnundefinedand ends up throwing an exception. Other browsers treat SVGs as HTMLCollections but IE treats them as SVGElement.Closes issue: #525
Reviewer checks
Required fields, to be filled out by PR reviewer(s)