feat(autocomplete-matches): use virtualNode only lookups #1604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autocomplete-matches uses the JavaScript DOM property
.type
to look at the type of input. This is trivial when you have a DOM node, but becomes a bit more complicated when you don't (e.g. AST implementations). Created a method on theVirtualNode
that just returns the DOM property lookup but is expected to be overridden for other implementations.It also tries to determine if the node is visible in the DOM, but that doesn't work for virtual node only runs, so I made it conditional on there being an
actualNode
to look at.Please double check the tests that I added all the same properties when converting to
queryFixture
.Reviewer checks
Required fields, to be filled out by PR reviewer(s)