Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rollback playground.html #1511

Closed
wants to merge 1 commit into from
Closed

chore: rollback playground.html #1511

wants to merge 1 commit into from

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Apr 23, 2019

  • playground.html was updated from a previously authored rule.

Closes issue: NA

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: << Name here >>

@jeeyyy jeeyyy requested a review from a team as a code owner April 23, 2019 11:39
@jeeyyy jeeyyy requested a review from WilcoFiers April 23, 2019 11:39
@jeeyyy jeeyyy changed the title chore: rollback playground chore: rollback playground.html Apr 23, 2019
@jeeyyy jeeyyy changed the title chore: rollback playground.html test: rollback playground.html Apr 23, 2019
WilcoFiers
WilcoFiers previously requested changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was updated by Prettier. There's no need to undo that.

@jeeyyy
Copy link
Contributor Author

jeeyyy commented Apr 23, 2019

@WilcoFiers - I understand that, but the contents of the file has changes from a PR for a rule (avoid-inline-spacing), which should not be the case.

@jeeyyy jeeyyy requested a review from WilcoFiers April 23, 2019 15:16
stephenmathieson
stephenmathieson requested changes Apr 23, 2019
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not updated, and Wilco's concern is still valid.

@jeeyyy
Copy link
Contributor Author

jeeyyy commented Apr 23, 2019

Closing, as it is not a concern. Will re-open after discussion with @WilcoFiers

@jeeyyy jeeyyy closed this Apr 23, 2019
@jeeyyy jeeyyy changed the title test: rollback playground.html chore: rollback playground.html Apr 25, 2019
@jeeyyy jeeyyy mentioned this pull request Apr 25, 2019
Merged
4 tasks
@jeeyyy jeeyyy deleted the chore-rollback-playground branch May 15, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson requested changes

@WilcoFiers WilcoFiers Awaiting requested review from WilcoFiers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeeyyy @WilcoFiers @stephenmathieson