fix: Allow aria idref(s) to be empty #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcysutton
previously approved these changes
Jul 16, 2018
jeeyyy
previously approved these changes
Jul 17, 2018
jeeyyy
reviewed
Jul 28, 2018
doc/rule-descriptions.md
Outdated
| | landmark-no-duplicate-banner | Ensures the document has no more than one banner landmark | Moderate | cat.semantics, best-practice | true | | ||
| | landmark-no-duplicate-contentinfo | Ensures the document has no more than one contentinfo landmark | Moderate | cat.semantics, best-practice | true | | ||
| | landmark-one-main | Ensures a navigation point to the primary content of the page. If the page contains iframes, each iframe should contain either no main landmarks or just one | Moderate | cat.semantics, best-practice | true | | ||
| | landmark-banner-is-top-level | Ensures the banner landmark is at top level | Moderate | cat.semantics, best-practice | true | |
There was a problem hiding this comment.
Multiple PR's where these changes for rule descriptions are shown :( revert here, See: https://github.com/dequelabs/axe-core/pull/1017/files#r205952776
There was a problem hiding this comment.
Hopefully once it's merged they'll go away. I think I must have forgotten to do a build when #1003 went in.
jeeyyy
approved these changes
Jul 28, 2018
|
We're saying there's no accessibility impact for any ARIA attribute when an idref value is missing?Looks simple enough. However, one concern I have is what if an idref value is missing due to an error, and developers won't realize something is broken by passing them all? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few issues open related to allowing empty idref(s) for ARIA:
Reviewer checks
Required fields, to be filled out by PR reviewer(s)