Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"group-labelledby" check to use the composed tree #426

Closed
WilcoFiers opened this issue Jul 12, 2017 · 4 comments
Closed

"group-labelledby" check to use the composed tree #426

WilcoFiers opened this issue Jul 12, 2017 · 4 comments
Assignees

Comments

@WilcoFiers
Copy link
Contributor

"group-labelledby" check to use the composed tree

@marcysutton
Copy link
Contributor

What if the same input name is referenced across the shadow boundary? Should we flag it since you can't use the same label idRef like we do in the other tests? Not sure how common that would be, but I was wondering what uses cases to test for.

@WilcoFiers
Copy link
Contributor Author

Do you mean that the labelledby points to different elements, but that those elements have the same accessible text? I guess that makes sense. Have a look at what happens when input elements with the same name exist in different shadow trees. Does the browser still consider them part of the same group? I'd suggest that only if it does, should we look to match names instead of just element references. WDYT?

@marcysutton
Copy link
Contributor

marcysutton commented Jul 20, 2017

The name grouping does not work across the boundary–radios aren't grouped together . So I don't think that's a valid use case. The test scenarios I think this should cover are:

  • Return false if the label referenced is outside of the boundary
  • Return true if the label is inside of the boundary
  • Return false if the inputs are spread across the boundary (this doesn't work because the fields aren't even associated)

@marcysutton
Copy link
Contributor

Closed with #458.

mrtnvh pushed a commit to mrtnvh/axe-core that referenced this issue Nov 24, 2023
…/webdriverjs (dequelabs#426)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants