fix(rule): allow impact to be configured (#2426)

dequelabs · Jul 28, 2020 · f325c75 · f325c75
1 parent 0aab922
commit f325c75
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/lib/core/base/rule.js b/lib/core/base/rule.js
@@ -593,6 +593,14 @@ Rule.prototype.configure = function(spec) {
 	if (spec.hasOwnProperty('matches')) {
 		this.matches = createExecutionContext(spec.matches);
 	}
+
+	if (spec.impact) {
+		assert(
+			constants.impact.includes(spec.impact),
+			`Impact ${spec.impact} is not a valid impact`
+		);
+		this.impact = spec.impact;
+	}
 };
 
 export default Rule;
diff --git a/test/core/base/rule.js b/test/core/base/rule.js
@@ -1967,5 +1967,19 @@ describe('Rule', function() {
 				'Function ID does not exist in the metadata-function-map: does-not-exist'
 			);
 		});
+		it('should override impact', function() {
+			var rule = new Rule({ impact: 'minor' });
+
+			assert.equal(rule._get('impact'), 'minor');
+			rule.configure({ impact: 'serious' });
+			assert.equal(rule._get('impact'), 'serious');
+		});
+		it('should throw if impact impact', function() {
+			var rule = new Rule({ impact: 'minor' });
+
+			assert.throws(function() {
+				rule.configure({ impact: 'hello' });
+			});
+		});
 	});
 });