chore: Test against ARIA practices (#3144)

* chore: Test against ARIA practices * test: run APG#main nightly * chore: sort out linting * chore: bump CI image * chore: Ready for review * chore: tweaks * chore: remove express * chore: undo unintended change * Apply suggestions from code review Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
dequelabs · Nov 9, 2021 · ed9ef99 · ed9ef99
1 parent 6f7e183
commit ed9ef99
Show file tree

Hide file tree

Showing 6 changed files with 862 additions and 108 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -5,7 +5,7 @@ defaults: &defaults
 
 unix_box: &unix_box
   docker:
-    - image: circleci/node:10-browsers
+    - image: circleci/node:16-browsers
 
 win_box: &win_box
   executor:
@@ -119,6 +119,16 @@ jobs:
       - run: npm run build
       - run: npm run test:act
 
+  # Run ARIA practices test cases
+  test_aria_practices:
+    <<: *defaults
+    <<: *unix_box
+    steps:
+      - checkout
+      - <<: *restore_dependency_cache_unix
+      - run: npm run build
+      - run: npm run test:apg
+
   # Test locale files
   test_locales:
     <<: *defaults
@@ -140,7 +150,7 @@ jobs:
       - run: npm run test:virtual-rules
 
   # Run the test suite for nightly builds.
-  test_nightly:
+  test_nightly_chrome:
     <<: *defaults
     <<: *unix_box
     steps:
@@ -155,6 +165,18 @@ jobs:
           CHROME_BIN="$(which google-chrome-beta)" && echo "CHROME_BIN: $CHROME_BIN"
           npm run test -- --browsers Chrome,FirefoxNightly
 
+  # Run the test suite for nightly builds.
+  test_nightly_aria_practices:
+    <<: *defaults
+    <<: *unix_box
+    steps:
+      - checkout
+      - <<: *restore_dependency_cache_unix
+      - run: npm run build
+      # install ARIA practices
+      - run: npm install w3c/aria-practices#main
+      - run: npm run test:apg
+
   # Test api docs can be built
   build_api_docs:
     <<: *defaults
@@ -269,6 +291,9 @@ workflows:
       - test_act:
           requires:
             - test_unix
+      - test_aria_practices:
+          requires:
+            - test_unix
       - test_locales:
           requires:
             - test_unix
@@ -354,6 +379,9 @@ workflows:
                 - develop
     jobs:
       - dependencies_unix
-      - test_nightly:
+      - test_nightly_chrome:
+          requires:
+            - dependencies_unix
+      - test_nightly_aria_practices:
           requires:
             - dependencies_unix
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -109,8 +109,17 @@ module.exports = {
         'no-use-before-define': 'off'
       }
     },
+    {
+      files: [
+        'test/aria-practices/**/*.js'
+      ],
+      env: {
+        mocha: true
+      }
+    },
     {
       files: ['test/**/*.js'],
+      excludedFiles: 'test/aria-practices/**/*.js',
       parserOptions: {
         ecmaVersion: 5
       },