Merge pull request #2092 from dequelabs/noDuplicate

fix(page-no-duplicate-contentinfo): do not fail when first element is inside landmark

lib/checks/keyboard/page-no-duplicate.js

@@ -15,7 +15,7 @@ axe._cache.set(key, true);
 let elms = axe.utils.querySelectorAllFilter(
 	axe._tree[0],
 	options.selector,
-	elm => elm !== virtualNode && axe.commons.dom.isVisible(elm.actualNode)
+	elm => axe.commons.dom.isVisible(elm.actualNode)
 );
 
 // Filter elements that, within certain contexts, don't map their role.
@@ -29,6 +29,8 @@ if (typeof options.nativeScopeFilter === 'string') {
 	});
 }
 
-this.relatedNodes(elms.map(elm => elm.actualNode));
+this.relatedNodes(
+	elms.filter(elm => elm !== virtualNode).map(elm => elm.actualNode)
+);
 
-return elms.length === 0;
+return elms.length <= 1;

test/checks/keyboard/page-no-duplicate.js

@@ -112,6 +112,21 @@ describe('page-no-duplicate', function() {
 			assert.isFalse(check.evaluate.apply(checkContext, params));
 		});
 
+		it('should pass when there are two elements and the first is contained within a nativeSccopeFilter', function() {
+			var options = {
+				selector: 'footer, [role="contentinfo"]',
+				nativeScopeFilter: 'article'
+			};
+			var params = checkSetup(
+				'<article>' +
+					'<footer id="target">Article footer</footer>' +
+					'</article>' +
+					'<footer>Body footer</footer>',
+				options
+			);
+			assert.isTrue(check.evaluate.apply(checkContext, params));
+		});
+
 		(shadowSupported ? it : xit)(
 			'elements if its ancestor is outside the shadow DOM tree',
 			function() {