Skip to content

Commit

Permalink
fix(color-contrast): mark more punctutions for review (#2126)
Browse files Browse the repository at this point in the history
  • Loading branch information
WilcoFiers authored Mar 25, 2020
1 parent ad46ace commit dc98afc
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/commons/text/unicode.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ function getPunctuationRegExp() {
* Reference: https://en.wikipedia.org/wiki/Supplemental_Punctuation
* -> \u2E00-\u2E7F Reference
*/
return /[\u2000-\u206F\u2E00-\u2E7F\\'!"#$%&()*+,\-.\/:;<=>?@\[\]^_`{|}~]/g;
return /[\u2000-\u206F\u2E00-\u2E7F\\'!"#$%&£¢¥§()*+,\-.\/:;<=>?@\[\]^_`{|}~±]/g;
}

/**
Expand Down
9 changes: 9 additions & 0 deletions test/commons/text/unicode.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,15 @@ describe('text.hasUnicode', function() {
});
assert.isTrue(actual);
});

it('returns true for strings with money signs and odd symbols', function() {
['£', '¢', '¥', '€', '§', '±'].forEach(function(str) {
var actual = axe.commons.text.hasUnicode(str, {
punctuations: true
});
assert.isTrue(actual);
});
});
});

describe('text.hasUnicode, has combination of unicode', function() {
Expand Down

0 comments on commit dc98afc

Please sign in to comment.