fix(meta-viewport) Don't check zooming/scaling ability in iframe-embe…

…dded pages (#2951) * only check meta-viewport for disabled scaling on the main page, not within iframes * remove matches that doesn't do anything on a check * add integration tests * fix integration test to not use scrdoc and include axe
dequelabs · Jun 3, 2021 · c6829fd · c6829fd
1 parent 3023e69
commit c6829fd
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 0 deletions.
diff --git a/lib/rules/meta-viewport-large.json b/lib/rules/meta-viewport-large.json
@@ -1,6 +1,7 @@
 {
   "id": "meta-viewport-large",
   "selector": "meta[name=\"viewport\"]",
+  "matches": "is-initiator-matches",
   "excludeHidden": false,
   "tags": ["cat.sensory-and-visual-cues", "best-practice"],
   "metadata": {

diff --git a/lib/rules/meta-viewport.json b/lib/rules/meta-viewport.json
@@ -1,6 +1,7 @@
 {
   "id": "meta-viewport",
   "selector": "meta[name=\"viewport\"]",
+  "matches": "is-initiator-matches",
   "excludeHidden": false,
   "tags": ["cat.sensory-and-visual-cues", "best-practice", "ACT"],
   "metadata": {

diff --git a/test/integration/rules/meta-viewport/frames/iframe-with-zooming-disabled.html b/test/integration/rules/meta-viewport/frames/iframe-with-zooming-disabled.html
@@ -0,0 +1,12 @@
+<html lang="en">
+  <head>
+    <script src="/axe.js"></script>
+    <meta name="viewport" content="maximum-scale=yes" />
+    <title>Test Page</title>
+  </head>
+  <body>
+    <main>
+      <h1>hello world</h1>
+    </main>
+  </body>
+</html>
diff --git a/test/integration/rules/meta-viewport/meta-viewport-pass3.html b/test/integration/rules/meta-viewport/meta-viewport-pass3.html
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html lang="en">
+  <head>
+    <meta id="mvp" name="viewport" content="maximum-scale=2;" />
+  </head>
+
+  <body>
+    <div id="mocha"></div>
+    <!-- iframe with zooming disabled should not fail the rule-->
+    <iframe src="frames/iframe-with-zooming-disabled"></iframe>
+  </body>
+</html>
diff --git a/test/integration/rules/meta-viewport/meta-viewport-pass3.json b/test/integration/rules/meta-viewport/meta-viewport-pass3.json
@@ -0,0 +1,5 @@
+{
+  "description": "meta-viewport passes when zooming is disabled on an iframe on the page",
+  "rule": "meta-viewport",
+  "passes": [["#mvp"]]
+}