DqElement in checkHelper

dequelabs · Aug 15, 2023 · c59ad63 · c59ad63
1 parent d1b07e1
commit c59ad63
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/lib/core/utils/check-helper.js b/lib/core/utils/check-helper.js
@@ -1,5 +1,5 @@
 import toArray from './to-array';
-import nodeSerializer from './node-serializer';
+import DqElement from './dq-element';
 import AbstractVirtualNode from '../base/virtual-node/abstract-virtual-node';
 
 /**
@@ -43,7 +43,7 @@ function checkHelper(checkResult, options, resolve, reject) {
           node = node.actualNode;
         }
         if (node instanceof window.Node) {
-          const nodeSpec = nodeSerializer.toSpec(node);
+          const nodeSpec = new DqElement(node);
           checkResult.relatedNodes.push(nodeSpec);
         }
       });

diff --git a/test/core/utils/check-helper.js b/test/core/utils/check-helper.js
@@ -68,6 +68,14 @@ describe('axe.utils.checkHelper', () => {
       const fixture = document.getElementById('fixture');
       const getSelector = node => node.selector;
 
+      it('returns DqElements', () => {
+        fixtureSetup('<div id="t1"></div><div id="t2"></div>');
+        const target = {};
+        const helper = axe.utils.checkHelper(target, noop);
+        helper.relatedNodes(fixture.children);
+        assert.instanceOf(target.relatedNodes[0], axe.utils.DqElement);
+      });
+
       it('should accept NodeList', () => {
         fixtureSetup('<div id="t1"></div><div id="t2"></div>');
         const target = {};

diff --git a/test/core/utils/node-serializer.js b/test/core/utils/node-serializer.js
@@ -77,7 +77,7 @@ describe('nodeSerializer', () => {
       });
     });
 
-    it('returns selector if fromFame, even if runOptions.selectors is false', () => {
+    it('returns selector if fromFrame, even if runOptions.selectors is false', () => {
       const dqElm = new DqElement(fixture);
       dqElm.fromFrame = true;
       const spec = nodeSerializer.dqElmToSpec(dqElm, {