fix(bypass): mark as needs review rather than failure (#2818)

dequelabs · Mar 1, 2021 · bb41b3e · bb41b3e
1 parent 4bd0acf
commit bb41b3e
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 10 deletions.
diff --git a/lib/rules/bypass.json b/lib/rules/bypass.json
@@ -3,6 +3,7 @@
   "selector": "html",
   "pageLevel": true,
   "matches": "bypass-matches",
+  "reviewOnFail": true,
   "tags": [
     "cat.keyboard",
     "wcag2a",

diff --git a/test/integration/full/bypass/fail.js b/test/integration/full/bypass/fail.js
@@ -17,13 +17,13 @@ describe('bypass fail test', function() {
     });
   });
 
-  describe('violations', function() {
+  describe('incomplete', function() {
     it('should find 1', function() {
-      assert.lengthOf(results.violations, 1);
+      assert.lengthOf(results.incomplete, 1);
     });
 
     it('should find html', function() {
-      assert.deepEqual(results.violations[0].nodes[0].target, ['html']);
+      assert.deepEqual(results.incomplete[0].nodes[0].target, ['html']);
     });
   });
 

diff --git a/test/integration/full/bypass/header-iframe-fail.js b/test/integration/full/bypass/header-iframe-fail.js
@@ -20,13 +20,13 @@ describe('bypass iframe test fail', function() {
     });
   });
 
-  describe('violations', function() {
+  describe('incomplete', function() {
     it('should find 1', function() {
-      assert.lengthOf(results.violations[0].nodes, 1);
+      assert.lengthOf(results.incomplete[0].nodes, 1);
     });
 
     it('should find #frame1', function() {
-      assert.deepEqual(results.violations[0].nodes[0].target, ['#fail1']);
+      assert.deepEqual(results.incomplete[0].nodes[0].target, ['#fail1']);
     });
   });
 

diff --git a/test/integration/full/bypass/header-iframe-pass.js b/test/integration/full/bypass/header-iframe-pass.js
@@ -21,9 +21,9 @@ describe('bypass iframe test pass', function() {
     });
   });
 
-  describe('violations', function() {
+  describe('incomplete', function() {
     it('should find none', function() {
-      assert.lengthOf(results.violations, 0);
+      assert.lengthOf(results.incomplete, 0);
     });
   });
 

diff --git a/test/integration/full/bypass/pass-tests.js b/test/integration/full/bypass/pass-tests.js
@@ -12,9 +12,9 @@ describe('bypass aria header test ' + window.location.pathname, function() {
     });
   });
 
-  describe('violations', function() {
+  describe('incomplete', function() {
     it('should find none', function() {
-      assert.lengthOf(results.violations, 0);
+      assert.lengthOf(results.incomplete, 0);
     });
   });