fix(dlitem): allow role=presentation on parent dl (#2301)

dequelabs · Jun 18, 2020 · 9857978 · 9857978
1 parent 2554f5c
commit 9857978
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/checks/lists/dlitem-evaluate.js b/lib/checks/lists/dlitem-evaluate.js
@@ -20,7 +20,7 @@ function dlitemEvaluate(node) {
 		return false;
 	}
 
-	if (!parentRole || parentRole === 'list') {
+	if (!parentRole || ['presentation', 'none', 'list'].includes(parentRole)) {
 		return true;
 	}
 

diff --git a/test/checks/lists/dlitem.js b/test/checks/lists/dlitem.js
@@ -30,11 +30,11 @@ describe('dlitem', function() {
 		assert.isTrue(checks.dlitem.evaluate.apply(null, checkArgs));
 	});
 
-	it('should fail if the dt element has a parent <dl> with role="presentation"', function() {
+	it('should pass if the dt element has a parent <dl> with role="presentation"', function() {
 		var checkArgs = checkSetup(
 			'<dl role="presentation"><dt id="target">My list item</dt></dl>'
 		);
-		assert.isFalse(checks.dlitem.evaluate.apply(null, checkArgs));
+		assert.isTrue(checks.dlitem.evaluate.apply(null, checkArgs));
 	});
 
 	it('should fail if the dt element has a parent <dl> with a changed role', function() {