fix(aria-allowed-attr): allow aria-details (#1956)

* fix(aria-allowed-attr): allow aria-details * fix test * test
dequelabs · Dec 20, 2019 · 79e1c58 · 79e1c58
1 parent 6b44454
commit 79e1c58
Show file tree

Hide file tree

Showing 5 changed files with 72 additions and 11 deletions.
diff --git a/doc/aria-supported.md b/doc/aria-supported.md
@@ -11,4 +11,3 @@ For a detailed description about how accessibility support is decided, see [How
 | aria-attribute   | axe-core support |
 | ---------------- | ---------------- |
 | aria-describedat | No               |
-| aria-details     | No               |
diff --git a/lib/commons/aria/index.js b/lib/commons/aria/index.js
@@ -68,7 +68,9 @@ lookupTable.attributes = {
 		unstandardized: true
 	},
 	'aria-details': {
-		unsupported: true
+		type: 'idref',
+		allowEmpty: true,
+		unsupported: false
 	},
 	'aria-disabled': {
 		type: 'boolean',
@@ -250,6 +252,7 @@ lookupTable.globalAttributes = [
 	'aria-controls',
 	'aria-current',
 	'aria-describedby',
+	'aria-details',
 	'aria-disabled',
 	'aria-dropeffect',
 	'aria-flowto',

diff --git a/test/integration/rules/aria-allowed-attr/failures.html b/test/integration/rules/aria-allowed-attr/failures.html
@@ -5,4 +5,3 @@
 
 <!-- unsupported attributes -->
 <div aria-describedat="#fail4" id="fail5">fail</div>
-<div aria-details="fail5" id="fail6">fail</div>
diff --git a/test/integration/rules/aria-allowed-attr/failures.json b/test/integration/rules/aria-allowed-attr/failures.json
@@ -1,12 +1,5 @@
 {
 	"description": "aria-allowed-attr failing tests",
 	"rule": "aria-allowed-attr",
-	"violations": [
-		["#fail1"],
-		["#fail2"],
-		["#fail3"],
-		["#fail4"],
-		["#fail5"],
-		["#fail6"]
-	]
+	"violations": [["#fail1"], ["#fail2"], ["#fail3"], ["#fail4"], ["#fail5"]]
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,4 +5,3 @@

		<!-- unsupported attributes -->
		<div aria-describedat="#fail4" id="fail5">fail</div>
		<div aria-details="fail5" id="fail6">fail</div>