Skip to content

Commit

Permalink
fix(types): Make any tag allowed (#2314)
Browse files Browse the repository at this point in the history
Tags (especially in custom rules) can be any string. Hard-coding this list prevents the ability to use custom tags.

This patch has the unfortunate side-effect of preventing intellisense in TypeScript-enabled editors, but provides more "technically correct" types.

Related #2312
  • Loading branch information
stephenmathieson authored Jun 24, 2020
1 parent 757aacd commit 5d98a04
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion axe.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
declare namespace axe {
type ImpactValue = 'minor' | 'moderate' | 'serious' | 'critical' | null;

type TagValue = 'wcag2a' | 'wcag2aa' | 'section508' | 'best-practice' | 'wcag21a' | 'wcag21aa';
type TagValue = string;

type ReporterVersion = 'v1' | 'v2' | 'raw' | 'raw-env' | 'no-passes';

Expand Down

0 comments on commit 5d98a04

Please sign in to comment.