feat(scope-value): add options for valid scope values (#2245)

dequelabs · May 22, 2020 · 44269ec · 44269ec
1 parent 2eadb15
commit 44269ec
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/lib/checks/tables/scope-value-evaluate.js b/lib/checks/tables/scope-value-evaluate.js
@@ -1,9 +1,7 @@
 function scopeValueEvaluate(node, options) {
-	options = options || {};
 	var value = node.getAttribute('scope').toLowerCase();
-	var validVals = ['row', 'col', 'rowgroup', 'colgroup'] || options.values;
 
-	return validVals.indexOf(value) !== -1;
+	return options.values.indexOf(value) !== -1;
 }
 
 export default scopeValueEvaluate;
diff --git a/lib/checks/tables/scope-value.json b/lib/checks/tables/scope-value.json
@@ -1,6 +1,9 @@
 {
 	"id": "scope-value",
 	"evaluate": "scope-value-evaluate",
+	"options": {
+		"values": ["row", "col", "rowgroup", "colgroup"]
+	},
 	"metadata": {
 		"impact": "critical",
 		"messages": {

diff --git a/test/checks/tables/scope-value.js b/test/checks/tables/scope-value.js
@@ -28,4 +28,16 @@ describe('scope-value', function() {
 
 		assert.isFalse(axe.testUtils.getCheckEvaluate('scope-value')(node));
 	});
+
+	it('should support options.values', function() {
+		fixture.innerHTML =
+			'<table><tr><td scope="hahahahanothx"></td></tr></table>';
+		var node = fixture.querySelector('td');
+
+		assert.isTrue(
+			axe.testUtils.getCheckEvaluate('scope-value')(node, {
+				values: ['hahahahanothx']
+			})
+		);
+	});
 });