-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support msbuild Directory.build.props #5475
Conversation
jeremylong
commented
Feb 19, 2023
- partially resolves MSBuild analyzer could (should?) check for props files as well #1948
- removes unnecessary interfaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding of interpolation is not in line with its documented behaviour (was previously already an error in interpolation method in the Model class).
core/src/main/java/org/owasp/dependencycheck/analyzer/MSBuildProjectAnalyzer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/owasp/dependencycheck/xml/pom/Model.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/owasp/dependencycheck/utils/InterpolationUtilTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/owasp/dependencycheck/utils/InterpolationUtil.java
Show resolved
Hide resolved
core/src/main/java/org/owasp/dependencycheck/analyzer/MSBuildProjectAnalyzer.java
Outdated
Show resolved
Hide resolved
da744ad
to
b9b0309
Compare
core/src/main/java/org/owasp/dependencycheck/analyzer/MSBuildProjectAnalyzer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/owasp/dependencycheck/data/nuget/DirectoryBuildPropsParser.java
Outdated
Show resolved
Hide resolved
@aikebah thank you for the review and comments. Everything should be good to go now - with the exception of the error handling. I will update that in a day or two before finalizing and merging this PR. |
YW, always keen to try and find potential issues before features are introduced. Have made a habit of reading specs and checking whether code is matching specs (though reading the specs of the MSBuild documentation leaves and itchy feeling due to their free format open-endedness so that you can only 'try your best to conform to whatever Visual Studio happens to do'). I prefer the formal specs where you can really determine what is conformant and what not. I think your updated naive implementation is the best we can do (which covers the only usages that I would trust to reliably work now and in the future in my projects were I to be a dotnet developer with Visual Studio solutions projects given the documentation that Microsoft has put up for it) |
9fcc995
to
1067d7a
Compare
- partially resolves #1948 - removes unnecassary interfaces
…rojectAnalyzer.java Co-authored-by: Hans Aikema <aikebah-github@aikebah.net>
…onUtilTest.java Co-authored-by: Hans Aikema <aikebah-github@aikebah.net>
1067d7a
to
405d8c8
Compare