Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Start testing on windows #109

Closed
wants to merge 2 commits into from
Closed

Start testing on windows #109

wants to merge 2 commits into from

Conversation

voxpelli
Copy link
Collaborator

Currently these tests are failing on Windows. They shouldn't be.

@voxpelli voxpelli added the dependencies Pull requests that update a dependency file label Sep 13, 2019
@voxpelli voxpelli self-assigned this Sep 13, 2019
@blakeembrey
Copy link
Collaborator

@voxpelli If you switch to double quotes around the globs, does it fix these tests?

@voxpelli voxpelli added enhancement help wanted and removed dependencies Pull requests that update a dependency file labels Sep 19, 2019
@voxpelli
Copy link
Collaborator Author

Seems like that unfortunately didn't do the trick @blakeembrey 🤔

@armano2
Copy link

armano2 commented Feb 9, 2020

async function resolveGlobbedPath (entries, cwd) {
if (typeof entries === 'string') entries = [entries]
debug('globby resolving', entries)
const resolvedEntries = await globby(entries, {
cwd,
absolute: true,
expandDirectories: false
})

resolveGlobbedPath is beeing invoked 2 times for all files

2nd time entries is already resolved and code is trying to glob files

  • d:\projects\dependency-check\test\index.js

in folder

  • d:\projects\dependency-check\test

@achingbrain
Copy link
Contributor

This just bit me so I've opened #127 which passes the tests for me on Windows. Looks like GH actions aren't running on PR branches though it's run on the branch in my fork here and Windows is green: https://github.com/achingbrain/dependency-check/actions/runs/362021862

@voxpelli
Copy link
Collaborator Author

Fixed by #127 🎉

@voxpelli voxpelli closed this Nov 24, 2020
@voxpelli voxpelli deleted the tests/windows branch November 24, 2020 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

4 participants