Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cargo): preserve version range using Less Than Equal #9956

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

caspermeijn
Copy link
Contributor

What are you trying to accomplish?

I added the Less Than Equal version range in #9828, but that doesn't respect the original precision of the version number. Fix that by using the normal update_version logic for such version ranges.

Anything you want to highlight for special attention from reviewers?

No, I reuse existing code

How will you know you've accomplished your goal?

I added a new test which reproduces my problem.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

Version ranges with "<=" are not respecting the original precision. Fix that by using the normal `update_version` logic for version ranges.
@kbukum1 kbukum1 enabled auto-merge June 24, 2024 23:30
@honeyankit honeyankit self-requested a review June 24, 2024 23:32
@kbukum1 kbukum1 merged commit 905d522 into dependabot:main Jun 24, 2024
37 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: rust:cargo Rust crates via cargo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants