Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't fail when a dependency doesn't have a previous version #9924

Merged
merged 8 commits into from
Jun 7, 2024

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Jun 6, 2024

What are you trying to accomplish?

In #9888 I moved the failure out of the service and into the Updater.

In this PR, I prevent the failure by removing the questionable update, and logging to tell us what's happening.

It seems there are various reasons why an update with no previous version will happen, but rather than failing the job or a group, we should log it and continue on.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

We should stop seeing the error being reported.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@jakecoffman jakecoffman marked this pull request as ready for review June 7, 2024 14:47
@jakecoffman jakecoffman requested a review from a team as a code owner June 7, 2024 14:47
@jakecoffman
Copy link
Member Author

I reran a job that previously errored and it didn't error this time, so this is working.

@jakecoffman jakecoffman merged commit b951923 into main Jun 7, 2024
121 checks passed
@jakecoffman jakecoffman deleted the dont-fail-when-no-previous-version-found branch June 7, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants