Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict type Dependabot::GoModules::MetaDataFinder #9919

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

raj-meka
Copy link
Contributor

@raj-meka raj-meka commented Jun 6, 2024

What are you trying to accomplish?

Sorbet Implementation for go_modules MetaDataFinder ruby file.

Anything you want to highlight for special attention from reviewers?

Please pay attention to the fixes in the go_modules MetaDataFinder ruby file.

How will you know you've accomplished your goal?

The sorbet rules will fire as needed.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@raj-meka raj-meka requested a review from a team as a code owner June 6, 2024 14:53
@github-actions github-actions bot added the L: go:modules Golang modules label Jun 6, 2024
@raj-meka raj-meka requested a review from JamieMagee June 6, 2024 14:54
@JamieMagee JamieMagee changed the title Strict type Dependabot::GoModules::MetaDateFinder Strict type Dependabot::GoModules::MetaDateFinder Jun 6, 2024
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Jun 6, 2024
jurre
jurre previously requested changes Jun 6, 2024
Copy link
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out the pull request template

@raj-meka raj-meka changed the title Strict type Dependabot::GoModules::MetaDateFinder Strict type Dependabot::GoModules::MetaDataFinder Jun 6, 2024
Copy link
Contributor

@GarryHurleyJr GarryHurleyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the warning here about the comment indent. It is not a fail, so it looks like the code should be good.

@raj-meka raj-meka force-pushed the Strict-type-DependabotGoModulesMetaDataFinder branch from cb59ffe to 77ef5b8 Compare June 6, 2024 21:45
@raj-meka raj-meka requested a review from jurre June 6, 2024 22:00
@raj-meka raj-meka force-pushed the Strict-type-DependabotGoModulesMetaDataFinder branch 2 times, most recently from 3512f14 to 6960ba7 Compare June 7, 2024 14:58
@raj-meka raj-meka force-pushed the Strict-type-DependabotGoModulesMetaDataFinder branch from 6960ba7 to 1bf1929 Compare June 7, 2024 19:28
@abdulapopoola abdulapopoola removed the request for review from jurre June 7, 2024 19:31
@abdulapopoola abdulapopoola dismissed jurre’s stale review June 7, 2024 19:32

PR template has been used

@raj-meka raj-meka merged commit 5b92376 into main Jun 7, 2024
48 checks passed
@raj-meka raj-meka deleted the Strict-type-DependabotGoModulesMetaDataFinder branch June 7, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: go:modules Golang modules sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants