Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new spoom srb coverage command #9898

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Jun 4, 2024

What are you trying to accomplish?

Fix the spoom coverage report generation.

It hasn't been generating a new report since 24th April due to the command we were using being deprecated.

Related to #9876

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

The deprecation warning is gone and the report is being generated again.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@JamieMagee JamieMagee requested a review from a team as a code owner June 4, 2024 18:30
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Jun 4, 2024
@JamieMagee JamieMagee force-pushed the jamiemagee/spoom-coverate-snapshot branch from a141e8b to 0a46fb9 Compare June 4, 2024 18:48
@abdulapopoola abdulapopoola merged commit 544fe20 into main Jun 4, 2024
53 checks passed
@abdulapopoola abdulapopoola deleted the jamiemagee/spoom-coverate-snapshot branch June 4, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants