Strict type Dependabot::Docker::Requirement::CredentialsFinder

docker/lib/dependabot/docker/utils/credentials_finder.rb

@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require "aws-sdk-ecr"
@@ -16,6 +16,7 @@ class CredentialsFinder
         AWS_ECR_URL = /dkr\.ecr\.(?<region>[^.]+)\.amazonaws\.com/
         DEFAULT_DOCKER_HUB_REGISTRY = "registry.hub.docker.com"
 
+        sig { params(credentials: T::Array[Dependabot::Credential]).void }
         def initialize(credentials)
           @credentials = credentials
         end
@@ -32,14 +33,13 @@ def credentials_for_registry(registry_hostname)
           build_aws_credentials(registry_details)
         end
 
+        sig { returns(String) }
         def base_registry
-          @base_registry ||= credentials.find do |cred|
-            cred["type"] == "docker_registry" && cred.replaces_base?
-          end
-          @base_registry ||= { "registry" => DEFAULT_DOCKER_HUB_REGISTRY, "credentials" => nil }
-          @base_registry["registry"]
+          @base_registry ||= T.let(nil, T.nilable(Dependabot::Credential))
+          @base_registry&.fetch("registry") || DEFAULT_DOCKER_HUB_REGISTRY
         end
 
+        sig { params(registry: String).returns(T::Boolean) }
         def using_dockerhub?(registry)
           registry == DEFAULT_DOCKER_HUB_REGISTRY
         end
@@ -76,7 +76,7 @@ def build_aws_credentials(registry_details)
 
           # Otherwise, we need to use the provided Access Key ID and secret to
           # generate a temporary username and password
-          @authorization_tokens ||= {}
+          @authorization_tokens ||= T.let({}, T.nilable(T::Hash[T.untyped, T.untyped]))
           @authorization_tokens[registry_hostname] ||=
             ecr_client.get_authorization_token.authorization_data.first.authorization_token
           username, password =

docker/lib/dependabot/docker/utils/helpers.rb

@@ -1,11 +1,16 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
+require "sorbet-runtime"
+
 module Dependabot
   module Docker
     module Utils
       HELM_REGEXP = /values[\-a-zA-Z_0-9]*\.ya?ml$/i
 
+      extend T::Sig
+
+      sig { params(file: DependencyFile).returns(T::Boolean) }
       def self.likely_helm_chart?(file)
         file.name.match?(HELM_REGEXP)
       end