Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce true sigil in npm_and_yarn ecosystem #9847

Merged
merged 1 commit into from
May 30, 2024

Conversation

JamieMagee
Copy link
Contributor

With #9800 and #9827, all of the npm_and_yarn ecosystem is now # typed: true with Sorbet. This change enforces this requirement with RuboCop to prevent regressions in type safety.

@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label May 28, 2024
@JamieMagee JamieMagee requested a review from a team as a code owner May 28, 2024 15:37
Copy link
Contributor

@sachin-sandhu sachin-sandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on comments.

@JamieMagee JamieMagee force-pushed the jamiemagee/npm-and-yarn-true-sigil branch from 6f6432f to 2c90137 Compare May 29, 2024 13:58
@sachin-sandhu sachin-sandhu force-pushed the jamiemagee/npm-and-yarn-true-sigil branch from 2c90137 to ea85ca2 Compare May 29, 2024 15:47
@sachin-sandhu sachin-sandhu force-pushed the jamiemagee/npm-and-yarn-true-sigil branch from ea85ca2 to baef6de Compare May 30, 2024 01:54
@sachin-sandhu sachin-sandhu merged commit 55febaf into main May 30, 2024
65 checks passed
@sachin-sandhu sachin-sandhu deleted the jamiemagee/npm-and-yarn-true-sigil branch May 30, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: javascript sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants