Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the dev-dependencies group in /updater with 10 updates #9520

Merged
merged 7 commits into from
Apr 23, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 17, 2024

Bumps the dev-dependencies group in /updater with 10 updates:

Package From To
debug 1.8.0 1.9.2
gpgme 2.0.23 2.0.24
rake 13.1.0 13.2.1
rspec 3.12.0 3.13.0
rubocop 1.58.0 1.63.2
rubocop-performance 1.19.1 1.21.0
rubocop-rspec 2.27.1 2.29.1
rubocop-sorbet 0.7.6 0.8.1
turbo_tests 2.2.0 2.2.3
webmock 3.19.1 3.23.0

Updates debug from 1.8.0 to 1.9.2

Release notes

Sourced from debug's releases.

v1.9.2

What's Changed

New Contributors

Full Changelog: ruby/debug@v1.9.1...v1.9.2

v1.9.1

Fix small issue to release with Ruby 3.3.0.

What's Changed

Full Changelog: ruby/debug@v1.9.0...v1.9.1

v1.9.0

This release fixes many issues reported after v1.8.0, introduce IRB integrated console and more.

What's Changed

... (truncated)

Commits
  • 0b77e82 v1.9.2
  • 6407c98 Format tables
  • a655f10 Mention IRB as the console in readme
  • ffbdb30 Use rb_iseqw_to_iseq to get iseq pointer
  • 75326e2 Fix name of rb_iseq_t struct
  • 6e9a127 Add Launchable in CI
  • 3564601 Fix flakey test "test_reponse_returns_correct_threads_info"
  • 98dad00 Separate setup and execution steps in CI
  • 68f7753 Add Session#deactivate_irb_integration
  • 935f903 Make irb_console toggleable with config update
  • Additional commits viewable in compare view

Updates gpgme from 2.0.23 to 2.0.24

Changelog

Sourced from gpgme's changelog.

2.0.24 January 31, 2024

  • Fix --clean option (#178, #179)
  • Add the ignore_mdc_error flag setter and getter (#180)
  • Add workaround for building gpgme with musl >= 1.2.4 (#181)
  • Don't add gem root to LOAD_PATH (#120)
Commits
  • ec4c9a9 Release 2.0.24
  • 238a081 Add workaround for building gpgme with musl >= 1.2.4
  • 7d6dc97 Remove duplicated tests
  • 2ac00ff Add the ignore_mdc_error flag setter and getter
  • fb4c588 Don't add gem root to LOAD_PATH
  • 2cc29d8 Revert comment about cleaning not being on by default
  • 0ce6037 Fix --clean option
  • See full diff in compare view

Updates rake from 13.1.0 to 13.2.1

Changelog

Sourced from rake's changelog.

=== 13.2.1

  • Suppressed "internal:array:52:in 'Array#each'" from backtrace by @​hsbt in #554
  • Bump actions/configure-pages from 4 to 5 by @​dependabot in #553

=== 13.2.0

Commits
  • d84f6ef Bump up 13.2.1
  • 8b33b36 Merge pull request #553 from ruby/dependabot/github_actions/actions/configure...
  • 99f6823 Merge pull request #554 from ruby/suppress-array-internal
  • 54950e0 Suppressed "<internal:array>:52:in 'Array#each'" from backtrace
  • 675498c Bump up 13.2.0
  • 3dc4277 Bump actions/configure-pages from 4 to 5
  • c68e010 Merge pull request #549 from ruby/dependabot/github_actions/dependabot/fetch-...
  • 2cb46b6 Merge pull request #551 from andrykonchin/ak/restore-truffleruby-on-ci
  • c342e96 Add TruffleRuby on CI
  • d569f0f Merge pull request #550 from ruby/dependabot/github_actions/ruby/setup-ruby-1...
  • Additional commits viewable in compare view

Updates rspec from 3.12.0 to 3.13.0

Commits

Updates rubocop from 1.58.0 to 1.63.2

Release notes

Sourced from rubocop's releases.

RuboCop 1.63.2

Bug fixes

  • #12843: Fix an error for Lint/MixedCaseRange when a character between Z and a is used in the regexp range. (@​koic)
  • #12846: Fix an error for RuboCop::Lockfile when there is no Bundler environment. (@​koic)
  • #12832: Fix an error for Style/ArgumentsForwarding when using block arg in nested method definitions. (@​koic)
  • #12841: Fix false negatives for Lint/UnreachableLoop when using pattern matching. (@​koic)
  • #12835: Allow global offenses to be disabled by directive comments. (@​earlopain)

Changes

  • #12845: Exclude debug/open_nonstop from Lint/Debugger by default. (@​koic)

RuboCop 1.63.1

Bug fixes

  • #12828: Fix a false positive for Lint/AssignmentInCondition if assigning inside a method call. (@​earlopain)
  • #12823: Fixed "uninitialized constant RuboCop::Lockfile::Bundler", caused when running RuboCop without bundler exec on codebases that use rubocop-rails. (@​amomchilov)

RuboCop 1.63

New features

Bug fixes

  • #12769: Fix a false positive for Lint/RedundantWithIndex when calling with_index with receiver and a block. (@​koic)
  • #12547: Added a comment recommending upgrading to the latest version of Rubocop in the error text when an Infinite loop detected error occurs. ([@​Hiroto-Iizuka][])
  • #12782: Fix an error for Style/Alias with EnforcedStyle: prefer_alias when calling alias_method with fewer than 2 arguments. (@​earlopain)
  • #12781: Fix an error for Style/ExactRegexpMatch when calling match without a receiver. (@​earlopain)
  • #12780: Fix an error for Style/RedundantEach when using reverse_each.each without a block. (@​earlopain)
  • #12731: Treat &. the same way as . for setter methods in Lint/AssignmentInCondition. ([@​jonas054][])
  • #12793: Fix false positives for Style/RedundantLineContinuation when using line continuation with modifier. (@​koic)
  • #12807: Fix false positives for Naming/BlockForwarding when using explicit block forwarding in block method and others. (@​koic)
  • #12796: Fix false positives for Style/EvalWithLocation when using eval with a line number from a method call or a variable. (@​koic)
  • #12794: Fix false positives for Style/RedundantArgument when when single-quoted strings for cntrl character. (@​koic)
  • #12797: Fix false positives for Style/RedundantLineContinuation when using line continuations with && or || operator in assignment. (@​koic)
  • #12793: Fix false positives for Style/RedundantLineContinuation when multi-line continuations with operators. (@​koic)
  • #12801: Fix incorrect autocorrect for Style/CollectionCompact when using delete_if. (@​koic)
  • #12789: Make Style/RedundantPercentQ safe on multiline strings. ([@​boardfish][])
  • #12802: Return global offenses for Naming/FileName and Naming/InclusiveLanguage for empty files. (@​earlopain)
  • #12804: Return global offenses for Style/Copyright when the file is empty. (@​earlopain)

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.63.2 (2024-04-16)

Bug fixes

  • #12843: Fix an error for Lint/MixedCaseRange when a character between Z and a is used in the regexp range. ([@​koic][])
  • #12846: Fix an error for RuboCop::Lockfile when there is no Bundler environment. ([@​koic][])
  • #12832: Fix an error for Style/ArgumentsForwarding when using block arg in nested method definitions. ([@​koic][])
  • #12841: Fix false negatives for Lint/UnreachableLoop when using pattern matching. ([@​koic][])
  • #12835: Allow global offenses to be disabled by directive comments. ([@​earlopain][])

Changes

  • #12845: Exclude debug/open_nonstop from Lint/Debugger by default. ([@​koic][])

1.63.1 (2024-04-10)

Bug fixes

  • #12828: Fix a false positive for Lint/AssignmentInCondition if assigning inside a method call. ([@​earlopain][])
  • #12823: Fixed "uninitialized constant RuboCop::Lockfile::Bundler", caused when running RuboCop without bundler exec on codebases that use rubocop-rails. ([@​amomchilov][])

1.63.0 (2024-04-08)

New features

Bug fixes

  • #12769: Fix a false positive for Lint/RedundantWithIndex when calling with_index with receiver and a block. ([@​koic][])
  • #12547: Added a comment recommending upgrading to the latest version of Rubocop in the error text when an Infinite loop detected error occurs. ([@​Hiroto-Iizuka][])
  • #12782: Fix an error for Style/Alias with EnforcedStyle: prefer_alias when calling alias_method with fewer than 2 arguments. ([@​earlopain][])
  • #12781: Fix an error for Style/ExactRegexpMatch when calling match without a receiver. ([@​earlopain][])
  • #12780: Fix an error for Style/RedundantEach when using reverse_each.each without a block. ([@​earlopain][])
  • #12731: Treat &. the same way as . for setter methods in Lint/AssignmentInCondition. ([@​jonas054][])
  • #12793: Fix false positives for Style/RedundantLineContinuation when using line continuation with modifier. ([@​koic][])
  • #12807: Fix false positives for Naming/BlockForwarding when using explicit block forwarding in block method and others. ([@​koic][])
  • #12796: Fix false positives for Style/EvalWithLocation when using eval with a line number from a method call or a variable. ([@​koic][])
  • #12794: Fix false positives for Style/RedundantArgument when when single-quoted strings for cntrl character. ([@​koic][])
  • #12797: Fix false positives for Style/RedundantLineContinuation when using line continuations with && or || operator in assignment. ([@​koic][])
  • #12793: Fix false positives for Style/RedundantLineContinuation when multi-line continuations with operators. ([@​koic][])
  • #12801: Fix incorrect autocorrect for Style/CollectionCompact when using delete_if. ([@​koic][])
  • #12789: Make Style/RedundantPercentQ safe on multiline strings. ([@​boardfish][])
  • #12802: Return global offenses for Naming/FileName and Naming/InclusiveLanguage for empty files. ([@​earlopain][])
  • #12804: Return global offenses for Style/Copyright when the file is empty. ([@​earlopain][])

Changes

  • #12813: Add rubocop-rspec_rails to suggested extensions and extension doc. ([@​ydah][])

... (truncated)

Commits
  • 56fe9e6 Cut 1.63.2
  • f3c506d Update Changelog
  • 1246c55 [Fix #12846] Fix an error for RuboCop::Lockfile
  • 1deecbd [Fix #12835] Allow global offenses to be disabled by directive comments
  • 0c34dbd Merge pull request #12845 from koic/exclude_debug_open_nonstop_from_lint_debu...
  • c9ebac6 Exclude debug/open_nonstop from Lint/Debugger
  • 2d39a72 [Fix #12843] Fix an error for Lint/MixedCaseRange
  • a032d91 Merge pull request #12841 from koic/fix_false_negatives_for_lint_unreachable_...
  • fb2bd23 Fix false negatives for Lint/UnreachableLoop
  • c6e0d4b Workaround for rubocop-rspec_rails 2.28
  • Additional commits viewable in compare view

Updates rubocop-performance from 1.19.1 to 1.21.0

Release notes

Sourced from rubocop-performance's releases.

RuboCop Performance 1.21.0

New features

  • #446: Support Prism as a Ruby parser (experimental). (@​koic)

Bug fixes

  • #437: Fix a false positive for Performance/ChainArrayAllocation when using select with block argument after select. (@​koic)
  • #448: Fix a false positive for Performance/RedundantBlockCall when using block.call with block argument. (@​koic)

Changes

RuboCop Performance 1.20.2

Bug fixes

  • #425: Fix a false positive for Performance/StringIdentifierArgument when using string interpolation with methods that don't support symbols with :: inside them. (@​earlopain)

RuboCop Performance 1.20.1

Bug fixes

  • #428: Fix false negatives for Performance/StringIdentifierArgument when using multiple string arguments. (@​koic)

RuboCop Performance 1.20.0 (The RubyConf Taiwan 2023 Edition)

New features

  • #384: Support optimized String#dup for Performance/UnfreezeString when Ruby 3.3+. (@​koic)

Bug fixes

  • #374: Fix an error for Performance/MapMethodChain when using map method chain without receiver. (@​koic)
  • #386: Fix a false negative for Performance/StringIdentifierArgument when using string interpolation. (@​earlopain)
  • #419: Make Performance/Count, Performance/FixedSize, Performance/FlatMap, Performance/InefficientHashSearch, Performance/RangeInclude, Performance/RedundantSortBlock, Performance/ReverseFirst, Performance/SelectMap, Performance/Size, Performance/SortReverse, and Performance/TimesMap cops aware of safe navigation operator. (@​koic)
  • #390: Fix a false negative for Performance/ReverseEach when safe navigation is between reverse and each. ([@​fatkodima][])
  • #401: Make Performance/Sum aware of safe navigation operator. (@​koic)

Changes

... (truncated)

Changelog

Sourced from rubocop-performance's changelog.

1.21.0 (2024-03-30)

New features

  • #446: Support Prism as a Ruby parser (experimental). ([@​koic][])

Bug fixes

  • #437: Fix a false positive for Performance/ChainArrayAllocation when using select with block argument after select. ([@​koic][])
  • #448: Fix a false positive for Performance/RedundantBlockCall when using block.call with block argument. ([@​koic][])

Changes

1.20.2 (2024-01-08)

Bug fixes

  • #425: Fix a false positive for Performance/StringIdentifierArgument when using string interpolation with methods that don't support symbols with :: inside them. ([@​earlopain][])

1.20.1 (2023-12-25)

Bug fixes

  • #428: Fix false negatives for Performance/StringIdentifierArgument when using multiple string arguments. ([@​koic][])

1.20.0 (2023-12-16)

New features

  • #384: Support optimized String#dup for Performance/UnfreezeString when Ruby 3.3+. ([@​koic][])

Bug fixes

  • #374: Fix an error for Performance/MapMethodChain when using map method chain without receiver. ([@​koic][])
  • #386: Fix a false negative for Performance/StringIdentifierArgument when using string interpolation. ([@​earlopain][])
  • #419: Make Performance/Count, Performance/FixedSize, Performance/FlatMap, Performance/InefficientHashSearch, Performance/RangeInclude, Performance/RedundantSortBlock, Performance/ReverseFirst, Performance/SelectMap, Performance/Size, Performance/SortReverse, and Performance/TimesMap cops aware of safe navigation operator. ([@​koic][])
  • #390: Fix a false negative for Performance/ReverseEach when safe navigation is between reverse and each. ([@​fatkodima][])
  • #401: Make Performance/Sum aware of safe navigation operator. ([@​koic][])

Changes

  • #389: Improve Performance/MapCompact to handle more safe navigation calls. ([@​fatkodima][])
  • #395: Enhance Performance/StringInclude to handle === method. ([@​fatkodima][])
  • #388: Require RuboCop 1.30+ as runtime dependency. ([@​koic][])
  • #380: Require RuboCop AST 1.30.0+. ([@​koic][])
Commits
  • 30f6669 Cut 1.21.0
  • 067c641 Update Changelog
  • 9d28120 Merge pull request #449 from koic/fix_false_positive_for_performance_redundan...
  • 0d98285 [Fix #448] Fix a false positive for Performance/RedundantBlockCall
  • d4d1875 Merge pull request #446 from koic/support_prism
  • 2059d28 Support Prism as a Ruby parser
  • 13aa3d1 Tweak specs for Performance/UnfreezeString
  • 9ba15dd Use RuboCop RSpec 2.27
  • 08ac312 Merge pull request #443 from koic/disalbe_performance_casecmp_by_default
  • 4dc1e5c [Fix #240] Disable Performance/Casecmp cop
  • Additional commits viewable in compare view

Updates rubocop-rspec from 2.27.1 to 2.29.1

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v2.29.1

  • Fix an error in the default configuration. (@​ydah)

RuboCop RSpec v2.29.0

  • Fix an autocorrect error for RSpec/ExpectActual. (@​bquorning)
  • Add new RSpec/UndescriptiveLiteralsDescription cop. (@​ydah)
  • Add new RSpec/EmptyOutput cop. (@​bquorning)

RuboCop RSpec v2.28.0

  • Extract RSpec Rails cops to a separate repository, rubocop-rspec_rails. The rubocop-rspec_rails repository is a dependency of rubocop-rspec and the cops related to rspec-rails are aliased (RSpec/Rails/Foo == RSpecRails/Foo) until v3.0 is released, so the change will be invisible to users until then. (@​ydah)
Changelog

Sourced from rubocop-rspec's changelog.

2.29.1 (2024-04-05)

  • Fix an error in the default configuration. ([@​ydah])

2.29.0 (2024-04-04)

  • Fix an autocorrect error for RSpec/ExpectActual. ([@​bquorning])
  • Add new RSpec/UndescriptiveLiteralsDescription cop. ([@​ydah])
  • Add new RSpec/EmptyOutput cop. ([@​bquorning])

2.28.0 (2024-03-30)

  • Extract RSpec Rails cops to a separate repository, rubocop-rspec_rails. The rubocop-rspec_rails repository is a dependency of rubocop-rspec and the cops related to rspec-rails are aliased (RSpec/Rails/Foo == RSpecRails/Foo) until v3.0 is released, so the change will be invisible to users until then. ([@​ydah])
Commits

Updates rubocop-sorbet from 0.7.6 to 0.8.1

Release notes

Sourced from rubocop-sorbet's releases.

v0.8.1

What's Changed

🛠 Other Changes

New Contributors

Full Changelog: Shopify/rubocop-sorbet@v0.8.0...v0.8.1

v0.8.0

What's Changed

[!NOTE] This version drops the runtime dependency that Sorbet/SignatureBuildOrder had on unparser, so if you had that dependency in your Gemfile for only this reason, you should be able to drop it now.

🛠 Other Changes

Full Changelog: Shopify/rubocop-sorbet@v0.7.8...v0.8.0

v0.7.8

What's Changed

🛠 Other Changes

Full Changelog: Shopify/rubocop-sorbet@v0.7.7...v0.7.8

v0.7.7

What's Changed

🛠 Other Changes

New Contributors

... (truncated)

Commits
  • 479aaef Bump version to v0.8.1
  • 23b9d82 Merge pull request #221 from Shopify/dependabot/bundler/rake-13.2.1
  • 1eb6517 Bump rake from 13.1.0 to 13.2.1
  • d5f72a2 Merge pull request #218 from Shopify/centralize_ruby_version
  • 107aa2e Remove TargetRubyVersion from config/rbi.yml
  • c15a2d2 Update Rubocop to 1.62.1
  • b43acc9 Centralize Ruby Version to .ruby-version
  • 7c44e60 Merge pull request #212 from Shopify/dependabot/github_actions/actions/stale-9
  • c5d0a19 Merge pull request #211 from Shopify/dependabot/github_actions/actions/checko...
  • b6b33d7 Merge pull request #216 from Shopify/dependabot/bundler/rspec-3.13.0
  • Additional commits viewable in compare view

Updates turbo_tests from 2.2.0 to 2.2.3

Release notes

Sourced from turbo_tests's releases.

v2.2.3

What's Changed

Full Changelog: serpapi/turbo_tests@v2.2.2...v2.2.3

v2.2.2

What's Changed

New Contributors

Full Changelog: serpapi/turbo_tests@v2.2.1...v2.2.2

v2.2.1

What's Changed

New Contributors

Full Changelog: serpapi/turbo_tests@v2.2.0...v2.2.1

Commits
  • bb814e1 Merge pull request #54 from serpapi/remove-json-gem-explicit-dependency
  • ddf5fbd Bump version to 2.2.3
  • 4f1cc37 Merge branch 'master' of github.com:serpapi/turbo_tests into remove-json-gem-...
  • ced6eb7 Revert "Merge pull request #49 from lcmen/fix-hash-extensions-for-latest-json"
  • 876a33d Merge pull request #50 from deivid-rodriguez/windows-support
  • 1f714bf Merge remote-tracking branch 'origin/master' into windows-support
  • 6ada9df Merge pull request #53 from javierjulio/patch-1
  • a3220a1 Remove ostruct require
  • 468ac62 Replace OpenStruct with Struct
  • 1fa426c Bump version to 2.2.2
  • Additional commits viewable in compare view

Updates webmock from 3.19.1 to 3.23.0

Changelog

Sourced from webmock's changelog.

3.23.0

  • Fixed HTTP.rb adapter to support streaming real responses when WebMock is enabled.

    Thanks to Viacheslav Nepomniashchikh for reporting and investigating this issue.

3.22.0

  • Addressed an issue in the HTTPClient adapter where memoized stubbed responses and memoized request_signatures were incorrectly persisted between subsequent requests (#1019). The implementation of a more robust thread-safety solution by Tom Beauvais in [PR #300](bblimke/webmock#300) not only resolved the memoization problem but also enhanced the overall thread safety of the adapter. This update ensures that stubbed responses and request signatures are correctly isolated to individual requests, improving both consistency and thread safety.

3.21.2

  • Corrected type checking in WebMock::Response#assert_valid_body! to accurately recognize Hash objects. Additionally, improved the clarity of the error message for unsupported body types, guiding users towards proper usage.

    Thanks to Jake Robb for reporting.

3.21.1

  • The stubbed Net::HTTPResponse#uri now returns request.uri, aligning it with the behavior of an actual Net::HTTPResponse.

    Thanks to Abe Voelker for reporting and to Victor Maslov and Gio Lodi for the suggested solution.

3.21.0

  • Don't use deprecated Rack::VERSION for Rack >= 3

    Thanks to Étienne Barrié

  • Updated HTTPClient adapter, to build request signature using the URI after filters have been applied.

    Thanks to Matt Brown

3.20.0

  • Optimised EmHttpRequestAdapter performance.

    Thanks to Ricardo Trindade

  • Removed runtime dependency on base64.

    Thanks to Earlopain

  • Typhoeus::Response objects constructed from stubbed responses now have all timing attributes set to 0.0.

    Thanks to James Brown

  • Optimised WebMock::Util::Headers by removing redundant freeze invocations.

    Thanks to Kazuhiro NISHIYAMA

... (truncated)

Commits
  • fc6a2ab Version 3.23.0
  • 43717a5 Fixed CI badge.
  • 216cad9 Fixed HTTP.rb adapter, to allow st...

    Description has been truncated

@dependabot dependabot bot requested a review from a team as a code owner April 17, 2024 16:06
@dependabot dependabot bot added dependencies ruby Dependabot pull requests that update Ruby code labels Apr 17, 2024
@dependabot dependabot bot force-pushed the dependabot/bundler/updater/dev-dependencies-c198de07a5 branch from 44ff28f to 3f97372 Compare April 18, 2024 15:47
@robaiken robaiken force-pushed the dependabot/bundler/updater/dev-dependencies-c198de07a5 branch from 3f97372 to 95d7c36 Compare April 19, 2024 16:54
@robaiken
Copy link
Contributor

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 22, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@jurre
Copy link
Member

jurre commented Apr 22, 2024

@dependabot recreate

Dependabot couldn't find the original pull request head commit, 3f97372.
@dependabot dependabot bot force-pushed the dependabot/bundler/updater/dev-dependencies-c198de07a5 branch from 40d1c7d to 049bc08 Compare April 22, 2024 12:34
@robaiken robaiken self-assigned this Apr 22, 2024
@github-actions github-actions bot added L: ruby:bundler RubyGems via bundler L: swift Swift packages labels Apr 22, 2024
@robaiken robaiken force-pushed the dependabot/bundler/updater/dev-dependencies-c198de07a5 branch from b68ea19 to 32c28a4 Compare April 23, 2024 12:28
Copy link
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robaiken for persevering on this one, looking good 👍

Could you open an issue to address the new cops that we should consider enabling? I imagine a lot of these could be auto-corrected and if we tackle them one by one it'll be manageable I think.

@robaiken robaiken merged commit 6bd3041 into main Apr 23, 2024
142 checks passed
@robaiken robaiken deleted the dependabot/bundler/updater/dev-dependencies-c198de07a5 branch April 23, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies L: ruby:bundler RubyGems via bundler L: swift Swift packages ruby Dependabot pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants