asynchronously create PRs #9485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Apr 12, 2024
|
@jeffwidman that might work, or maybe it's not as big of a deal as I think. If we could make the logs clear to read while doing this is would be great to roll out to all updates. |
|
Yeah, I've leveraged the thread prefix idea before in both Python and Go very effectively for debugging async bugs in other projects, and every time it was so helpful, especially since I could just grep through the logfile to jump past all the noise when following one specific thread... But as you say, try it and see how bad it is first. 🕺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR creation process requires gathering a significant amount of metadata which is IO heavy. Rather than wait for that to finish, we can pop that in a thread and continue on with the next updates.
Testing locally against dependabot-core this lead to a 30% reduction in the job runtime, but it's very dependent on if there's a lot of PRs to create.
The major downside of this is that the logs become more difficult to read because the metadata gathering overlaps with the output for the next dependency, so I've put this behind an experiment and we can enable it on customers that are hitting the timeout.