Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise a proper user error when package.json includes just a dummy string #8747

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Raise a proper user error when package.json includes just a dummy string #8747

merged 2 commits into from
Dec 13, 2024

Conversation

deivid-rodriguez
Copy link
Contributor

No description provided.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner January 9, 2024 19:18
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/raise-package-json-just-a-string branch from db1bd68 to 1aeec54 Compare January 9, 2024 19:34
@abdulapopoola
Copy link
Member

on 2nd thoughts; I think this error might be common across ecosystems; should it be moved to the FileParser helper?

@deivid-rodriguez
Copy link
Contributor Author

🤔, the fact that the parsed package.json file should be a Ruby Hash seems quite specific to NPM ecosystem to me! I guess we have similar situations in other ecosystems but it's not clear to me how to generalize this error control.

@jeffwidman jeffwidman enabled auto-merge (squash) December 13, 2024 00:28
@jeffwidman jeffwidman merged commit a6d9362 into main Dec 13, 2024
67 checks passed
@jeffwidman jeffwidman deleted the deivid-rodriguez/raise-package-json-just-a-string branch December 13, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulapopoola abdulapopoola abdulapopoola approved these changes

@jeffwidman jeffwidman jeffwidman approved these changes

Assignees
No one assigned
Labels
L: javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deivid-rodriguez @abdulapopoola @jeffwidman