Create feature flag for Grouped security updates #8529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9365316 to
e9ccc8c
Compare
ryanbrandenburg
commented
Dec 5, 2023
| @@ -15,6 +15,7 @@ class CreateGroupSecurityUpdatePullRequest | |||
| include GroupUpdateCreation | |||
|
|
|||
| def self.applies_to?(job:) | |||
| return false if Dependabot::Experiments.enabled?(:grouped_security_updates_disabled) | |||
There was a problem hiding this comment.
I recognize that it's a bit weird to phrase it like this, but I need the default case to be grouped_security_updates being on and the way Dependabot::Experiments works is it's falsy by default.
ryanbrandenburg
commented
Dec 5, 2023
| @@ -209,8 +209,12 @@ | |||
| context "when there is an exception that blocks PR creation (cloud)" do | |||
| before do | |||
| allow(api_client).to receive(:create_pull_request).and_raise(StandardError, "oh no!") | |||
| allow(Dependabot::Experiments).to receive(:enabled?).with(:record_ecosystem_versions).and_return(true) | |||
There was a problem hiding this comment.
As far as I can tell doing it this way really only worked while we had a single call against enabled?. Since we already had the reset! method I figured we could make use of it instead of mocking things so that later levels of abstraction have an easier time handling things.
ryanbrandenburg
commented
Dec 5, 2023
| @@ -232,10 +236,6 @@ | |||
| end | |||
| end | |||
|
|
|||
| before do | |||
| allow(Dependabot::Experiments).to receive(:enabled?).with(:record_update_job_unknown_error).and_return(false) | |||
There was a problem hiding this comment.
These explicit mocks were not needed once we stop mocking (default to false), so I deleted them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a feature flag for Grouped security updates.