Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types for FileFetchers::Base #8327

Merged
merged 12 commits into from
Nov 13, 2023
Merged

Types for FileFetchers::Base #8327

merged 12 commits into from
Nov 13, 2023

Conversation

JamieMagee
Copy link
Contributor

No description provided.

@JamieMagee JamieMagee requested a review from a team as a code owner November 3, 2023 00:31
@github-actions github-actions bot added L: java:gradle Maven packages via Gradle L: git:submodules Git submodules labels Nov 3, 2023
@JamieMagee
fetch_files is now an abstract method
83f9363 
This should probably be `protected`, but `public` is okay for now.
@JamieMagee
make sure fetch_files inherits
b1c1310
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: elixir:hex Elixir packages via hex L: go:modules Golang modules L: github:actions GitHub Actions L: elm Elm packages L: terraform Terraform packages L: docker Docker containers L: rust:cargo Rust crates via cargo L: dotnet:nuget NuGet packages via nuget or dotnet L: java:maven Maven packages via Maven L: dart:pub Dart packages via pub L: javascript L: python L: swift Swift packages labels Nov 3, 2023
@jakecoffman jakecoffman merged commit 641de67 into main Nov 13, 2023
@jakecoffman jakecoffman deleted the jamiemagee/file-fetcher-base branch November 13, 2023 18:17
@CONDEVIRSMARK

This comment was marked as off-topic.

Sign in to view
@jakecoffman jakecoffman mentioned this pull request Dec 4, 2023
Merged
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecoffman jakecoffman jakecoffman approved these changes

Assignees
No one assigned
Labels
L: dart:pub Dart packages via pub L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: elixir:hex Elixir packages via hex L: elm Elm packages L: git:submodules Git submodules L: github:actions GitHub Actions L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo L: swift Swift packages L: terraform Terraform packages sorbet 🍦 Relates to Sorbet types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamieMagee @CONDEVIRSMARK @jakecoffman