Raise expected errors when unsupported PNPM versions are used #8147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7a99bc to
b3207fd
Compare
c14f810 to
a7b7ecb
Compare
jakecoffman
approved these changes
Oct 6, 2023
abdulapopoola
approved these changes
Oct 6, 2023
yeikel
reviewed
Oct 11, 2023
133fc35 to
62d2982
Compare
1e4fe03 to
ffc5bb5
Compare
The locked_version name wrongly suggests that the version is picked up from the lockfile.
Unless `packageManager` is used in `package.json`, using `pnpm --version` will always return the latest version we have installed, so we won't be able to detect unsupported versions unless the version is requested explicitly in `package.json` file. This way we'll be able to detect running the latest PNPM against very old lockfiles and raise an error in those situations.
ffc5bb5 to
907b518
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7500.
I expect this to fix a bunch of errors in our internal board, but of course will also break for repos where it's actually working.
I don't think this needs a deprecation changelog since we have documented v7 and v8 as the only supported versions from the beginning.
#7298 would make transition easier for users but I think pnpm v6 is old enough so that this PR does not need to block on that feature.