Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semver #8005

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Update semver #8005

merged 1 commit into from
Sep 12, 2023

Conversation

jurre
Copy link
Member

@jurre jurre commented Sep 11, 2023

This transitive version of semver has a vulnerability, let's patch it

@jurre jurre requested a review from a team as a code owner September 11, 2023 14:43
@jurre jurre force-pushed the jurre/update-semver branch from 2bcb6da to fe4b17a Compare September 11, 2023 14:44
@yeikel
Copy link
Contributor

yeikel commented Sep 11, 2023

Can we configure dependabot to take care of this? Or we don't do that intentionally?

@yeikel
Copy link
Contributor

yeikel commented Sep 11, 2023

Also, the latest version is 7.5.4

Is there any reason to stick to this older version instead?

@jurre
Copy link
Member Author

jurre commented Sep 12, 2023

Also, the latest version is 7.5.4

Is there any reason to stick to this older version instead?

This is a transitive dependency of @dependabot/yarn-lib that is constrained to ^5.1.0, since yarn 1 is not getting updates, yarn-lib is not getting updates so we can't rely on dependabot for these, and we need to patch them manually

We are on a recent version for the top-level semver that we depend on.

This transitive version of semver has a vulnerability, let's patch it
@jurre jurre force-pushed the jurre/update-semver branch from fe4b17a to f2854b6 Compare September 12, 2023 12:24
@jurre jurre merged commit ff4b17e into main Sep 12, 2023
@jurre jurre deleted the jurre/update-semver branch September 12, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants