Bubble up expected pub security update errors to the user #7880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
approved these changes
Aug 23, 2023
3df28ac to
0cc61ea
Compare
jeffwidman
reviewed
Aug 23, 2023
| # This security update would require unlocking other packages, which is not currently supported. | ||
| # Because of that, return original requirements, so that no requirements are actually updated and | ||
| # the error bubbles up as security_update_not_possible to the user. | ||
| return depedency.requirements if breaking_changes.size > 1 |
There was a problem hiding this comment.
Is depedency a typo? If so, I'm actually kinda surprised Rubocop isn't able to flag this.
There was a problem hiding this comment.
😮 Nice catch! It sounds like a changed one unexpected error with another 😬. Will fix!
Regarding catching this, I think a spell checker would catch this easily?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow up to #7446.