Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly require dependabot/utils before usage #7800

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

All other ecosystems do it:

$ rg ^Dependabot::Utils.register_always_clone -B1
go_modules/lib/dependabot/go_modules.rb
21-require "dependabot/utils"
22:Dependabot::Utils.register_always_clone("go_modules")

pub/lib/dependabot/pub.rb
20-require "dependabot/utils"
21:Dependabot::Utils.register_always_clone("pub")

swift/lib/dependabot/swift.rb
21-require "dependabot/utils"
22:Dependabot::Utils.register_always_clone("swift")

terraform/lib/dependabot/terraform.rb
21-require "dependabot/utils"
22:Dependabot::Utils.register_always_clone("terraform")

npm_and_yarn/lib/dependabot/npm_and_yarn.rb
28-require "dependabot/utils"
29:Dependabot::Utils.register_always_clone("npm_and_yarn")

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner August 11, 2023 20:06
All other ecosystems do it:

```
$ rg ^Dependabot::Utils.register_always_clone -B1
go_modules/lib/dependabot/go_modules.rb
21-require "dependabot/utils"
22:Dependabot::Utils.register_always_clone("go_modules")

pub/lib/dependabot/pub.rb
20-require "dependabot/utils"
21:Dependabot::Utils.register_always_clone("pub")

swift/lib/dependabot/swift.rb
21-require "dependabot/utils"
22:Dependabot::Utils.register_always_clone("swift")

terraform/lib/dependabot/terraform.rb
21-require "dependabot/utils"
22:Dependabot::Utils.register_always_clone("terraform")

npm_and_yarn/lib/dependabot/npm_and_yarn.rb
28-require "dependabot/utils"
29:Dependabot::Utils.register_always_clone("npm_and_yarn")
```
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/explicit-require branch from 6e8439f to cf5b766 Compare August 11, 2023 20:44
@deivid-rodriguez deivid-rodriguez enabled auto-merge (squash) August 11, 2023 20:48
@deivid-rodriguez deivid-rodriguez merged commit 84e3dbf into main Aug 11, 2023
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/explicit-require branch August 11, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants