Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cancel full CI runs on main #7757

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

Since CI on PRs only runs depending on changed files, I think it's good to have an after-merge full CI for every PR.

Solution taken from https://stackoverflow.com/a/70972844/143243.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner August 7, 2023 19:22
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This would have prevented this failure/cancellation: 58edfc3

Since CI on PRs only runs depending on changed files, I think it's good
to have an after-merge full CI for every PR.
@jeffwidman jeffwidman force-pushed the deivid-rodriguez/dont-cancel-main branch from 488105e to b417e0c Compare August 7, 2023 19:30
@jeffwidman jeffwidman enabled auto-merge (squash) August 7, 2023 19:30
@jeffwidman
Copy link
Member

Let's land this one ASAP so we stop getting cancellations on main.

@jeffwidman jeffwidman merged commit 77caeef into main Aug 7, 2023
@jeffwidman jeffwidman deleted the deivid-rodriguez/dont-cancel-main branch August 7, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants