Move the Pipfile/Pipfile.lock fixtures to a clearly named folder
#7700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does two things: 1. Moves the files in the `lockfiles` directory to the `pipfile_files` directory. 2. Moves the files in the `pipfiles` directory to the `pipfile_files` directory. All the files in `lockfiles` are actually specific to `pipenv` and their `pipfile.lock` file format. So I was a bit surprised because `poetry` also has a lockfile format... but those are over in `pyproject_locks` dir. I think what happened is that when `pipenv` popularized the `Pipfile`/`Pipfile.lock` format, there was a lot of initial excitement that it might become _the_ lockfile format within Python. So Grey may have called it `lockfile` assuming that other tooling would start to migrate towards this. However, `pipenv` made some design choices that made it a ["fails-to-take-over-the-world-because-it-tries-to-do-too-much"](https://hynek.me/articles/python-app-deps-2018/) type of tool. At first I started by merely renaming the folder from `lockfiles` to `pipfile_lockfiles`. However, while I was working regenerating the `pipfile.lock` files (#7697) I found it a royal pain to jump back and forth between two folders where one holds the input `Pipfile` and the other holds the output `Pipfile.lock` files. And the lockfiles already have a `.lock` suffix. So instead merging them into a single folder makes it easier to spot when a file should be regenerated into a lockfile vs when it'll fail to even generate a lockfile. So this hopefully makes things a lot clearer / less ambiguous for anyone working on this section of code.
mctofu
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things:
lockfilesdirectory to thepipfile_filesdirectory.pipfilesdirectory to thepipfile_filesdirectory.All the files in
lockfilesare actually specific topipenvand theirpipfile.lockfile format. So I was a bit surprised becausepoetryalso has a lockfile format... why aren't those also in thelockfilesdirectory? But instead those are over inpyproject_locksdir (which is actually much more convenient for navigating the fixtures!).I think what happened is that when
pipenvpopularized thePipfile/Pipfile.lockformat, there was a lot of initial excitement that it might become the lockfile format within Python. So Grey may have called itlockfileassuming that other tooling would start to migrate towards this. However,pipenvmade some design choices that made it a "fails-to-take-over-the-world-because-it-tries-to-do-too-much" type of tool.At first I started by merely renaming the folder from
lockfilestopipfile_lockfiles.However, while I was working regenerating the
pipfile.lockfiles (#7697) I found it a royal pain to jump back and forth between two folders where one holds the inputPipfileand the other holds the outputPipfile.lockfiles. And the lockfiles already have a.locksuffix. So instead merging them into a single folder makes it easier to spot when a file should be regenerated into a lockfile vs when it'll fail to even generate a lockfile.So this hopefully makes things a lot clearer / less ambiguous for anyone working on this section of code.