Fixup pip_version_resolver specs
#7699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulapopoola
approved these changes
Aug 2, 2023
be56b9b to
54b1a0e
Compare
While working on the PR to drop support for Python 3.6, I noticed these specs could use some tidying up: 1. `3.7` will soon be dropped, so bumped the "latest" version to `3.11`. 2. We had no explicit test of what happens when an outdated Python version was specified. Finally, the biggest change is removing the test of "old python version supported by Dependabot but not supported by a newer version of the library". The problem is that while nice to have the scenario it's testing is becoming less realistic. Overall (and I say this as someone who helps maintain several popular Python open source libraries) the Python ecosystem has been aligning pretty closely to the upstream version support lifecycle. Ie, library maintainers are starting to align when they drop support for old python versions with the upstream EOL cycle. Similarly, we're moving towards here in Dependabot. So it's going to be really hard to find an example of a library that releases a new version dropping support for a Python version that isn't EOL'd... or if it is EOL'd, then most likely we've dropped support for that Python version here in Dependabot. And even if I do manage to track down a library doing this, or mock a fake response from PyPI, it'll be a brittle test because every year we'll be dropping support for that old version. So instead I think the test of "that is set to a python version no longer supported by Dependabot" is a more realistic test scenario. I also tidied up some similar examples of this test to be consistent in formatting... their contents didn't change.
54b1a0e to
bb7639f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the PR to drop support for Python 3.6, I noticed these specs could use some tidying up:
3.7will soon be dropped, so bumped the "latest" version to3.11.Finally, the biggest change is removing the test of "old python version supported by Dependabot but not supported by a newer version of the library". The problem is that the test scenario, while nice to have, is becoming less realistic.
Overall (and I say this as someone who helps maintain several popular Python open source libraries) the Python ecosystem has been aligning pretty closely to the upstream version support lifecycle. Ie, library maintainers are starting to align when they drop support for old python versions with the upstream EOL cycle.
Similarly, we're moving towards here in Dependabot.
So it's going to be really hard to find an example of a library that releases a new version dropping support for a Python version that isn't EOL'd... or if it is EOL'd, then most likely we've dropped support for that Python version here in Dependabot.
And even if I do manage to track down a library doing this, or mock a fake response from PyPI, it'll be a brittle test because every year we'll be dropping support for that old version.
So instead I think the test of "that is set to a python version no longer supported by Dependabot" is a more realistic test scenario.
This is similar to the changes I already made for other Python package managers over in:
poetrytest of oldest supported python version to 3.8 #7691