Refresh PyPI response mocks #7682
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our PyPI mocks were originally created in 2017 before they replaced the back end with Warehouse, which was a complete rewrite: * https://github.com/dependabot/dependabot-core/commits/697d7f90fc0bf97c1c9d6004de7e8629483a101a/spec/fixtures/python/pypi_simple_response.html?browsing_rename_history=true&new_path=python/spec/fixtures/pypi/pypi_simple_response.html&original_branch=main * https://pyfound.blogspot.com/2018/03/warehouse-all-new-pypi-is-now-in-beta.html Ever since I realized this, I've felt a bit nervous about our tests. Warehouse has mostly retained backwards compatibility in their APIs, but there were a few small changes, and also new fields. So here I simply refreshed the mock by pulling up the current response from PyPI, then updated any unit tests that needed fixing. While working on this, I noticed that the raw `simple` API that returns HTML is now offered with a JSON schema, but migrating to that it out of scope of this PR.
7f59dbb to
10b3c0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our PyPI mocks were originally created in 2017 before they replaced the back end with Warehouse, which was a complete rewrite:
Ever since I realized this, I've felt a bit nervous about our tests.
Warehouse has mostly retained backwards compatibility in their APIs, but there were a few small changes, and also new fields.
So here I simply refreshed the mock by pulling up the current response from PyPI, then updated any unit tests that needed fixing.
While working on this, I noticed that the raw
simpleAPI that returns HTML is now offered with a JSON schema, but migrating to that it out of scope of this PR.Fix: #5723