-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cd: correctly find workspace.dependencies-declared dependencies and their Cargo.toml #7649
cd: correctly find workspace.dependencies-declared dependencies and their Cargo.toml #7649
Conversation
Thanks for picking this up!
Ah, that explains why I kept running into problems when I'd tried to write the test myself. I'm about to walk out the door to go camping, so hopefully someone else on the team can take a look... but if not, I'm happy to take a look next week. If you don't hear from someone by Wednesday, feel free to leave a comment and tag me by name as a reminder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
I'm not sure why the one Updater test is failing but it's not related to these changes.
I also looked at the test repo and although it differs slightly from what's described in #5864, it looks correct.
Also, the requests to the test fixtures are all stubbed out so it's okay to reference the test repo 👍🏾
This is now in production. |
That's a great news, many thanks for your support! |
Thanks for helping to make better @ggawryal ! |
I've decided to pick up #5865 as fixing the issue is quite urgent for my project. Added some more code to fetch
[workspace.dependencies]
from the root manifest, because extendingrequired_path?
function was not sufficient. Added a test as well - previously running dependabot on the repository I've attached to the test was finishing with a failure.Closes #5864.