Ignore tags not matching prefix, when workflow is pinned to SHAs #7430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I broke common CI apparently. Back to WIP. |
fd4c499 to
ece2a89
Compare
|
I think it should be fixed now but I'd like to confirm that the smoke test failure is not related to this PR. |
jurre
approved these changes
Jun 14, 2023
|
Great, thanks for checking that! |
ece2a89 to
d717e1b
Compare
d717e1b to
4194887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating explicit tags that include version numbers in their name in GitHub Actions workflows, we only update to tags that respect the existing format.
For example, if a workflow is pinned to the v2.3.6 tag through
github/codeql-action@v2.3.6and the action's author tagscodeql-bundle-v2.13.4, then Dependabot won't create updates.However, when the workflow is pinned to the specific commit for that tag, for example like this
github/codeql-action@83f0fe6c4988d98a455712a27f0255212bba9bd4 # v2.3.6, then Dependabot will still create an update togithub/codeql-action@cdcdbb579706841c47f7063dda365e292e5cad7a # v2.13.4.This PR fixes the problem by ensuring the format is respected, not only for explicit tags, but also for the tags corresponding to explicit SHA pins.