Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing cache prunes #7295

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Fix missing cache prunes #7295

merged 1 commit into from
Aug 11, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

Just pushing this change to see which specs fail.

@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label May 11, 2023
@deivid-rodriguez deivid-rodriguez mentioned this pull request May 11, 2023
Closed
@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review May 11, 2023 12:58
@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner May 11, 2023 12:58
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/missing-cache-prunes branch from 5b8992d to d7c2176 Compare June 26, 2023 11:45
@deivid-rodriguez
Copy link
Contributor Author

I rebased this PR now that #7296 has been shipped. Happily no complaints so far about #7296 by the way 🎉.

@jeffwidman
Copy link
Member

Took a look, but I have minimal context on this one... @jurre / @deivid-rodriguez should we ship this or hold off?

@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/missing-cache-prunes branch from d7c2176 to 217d0c6 Compare August 11, 2023 09:16
@jurre @deivid-rodriguez
Do not check only unlocked gems for pruning
ddb875c 
We're seeing an issue with bundler updates not correctly pruning all the
old cached dependencies that have been removed that we believe might be
caused by this check.
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/missing-cache-prunes branch from 217d0c6 to ddb875c Compare August 11, 2023 10:07
@deivid-rodriguez deivid-rodriguez merged commit 9f53299 into main Aug 11, 2023
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/missing-cache-prunes branch August 11, 2023 10:55
@deivid-rodriguez deivid-rodriguez mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurre jurre jurre approved these changes

Assignees
No one assigned
Labels
L: ruby:bundler RubyGems via bundler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deivid-rodriguez @jeffwidman @jurre