fix Poetry not using system git #5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavera
reviewed
Sep 12, 2022
jurre
approved these changes
Sep 12, 2022
jeffwidman
approved these changes
Sep 12, 2022
| @@ -177,6 +177,11 @@ def updated_lockfile_content_for(pyproject_content) | |||
| "#{NativeHelpers.python_requirements_path}") | |||
| end | |||
|
|
|||
| # use system git instead of the pure Python dulwich | |||
| unless python_version&.start_with?("3.6") | |||
There was a problem hiding this comment.
🤦 so looking forward to dropping 3.6 and then we don't have to maintain these...
7b50dc7 to
040882b
Compare
pavera
approved these changes
Sep 12, 2022
040882b to
4ff5f84
Compare
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5655
Poetry recently released 1.2.0 which uses dulwich, a pure Python implementation of Git. Like other ecosystems, we actually want to use the system Git with Dependabot so the Git shim will rewrite URLs to be HTTPS.
But also, in #5655 we are probably seeing a bug in dulwich that doesn't honor proxy authentication settings in the
http_proxyenvironment variables. I tested this change locally and it fixed my reproduction repo.