-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump composer/composer from 2.3.9 to 2.4.1 in /composer/helpers/v2 #5577
build(deps): bump composer/composer from 2.3.9 to 2.4.1 in /composer/helpers/v2 #5577
Conversation
2922823
to
58fb0bb
Compare
49663e1
to
99c57ea
Compare
de997bc
to
8ba394d
Compare
Test failing because Composer also has to be bumped in the dockerfile: dependabot-core/composer/spec/dependabot/composer_spec.rb Lines 11 to 18 in 4e854a5
But need to coordinate this to get Dependabot to first update it to the latest, then push the dockerfile change over the top of that. |
Looking at the changelog, there's actually a lot of changes in Composer, some of which may be useful to us... ie, we may be able to replace our native ruby re-implementations with simple flags passed to composer for some things. So I don't want to be in a hurry to merge this one until I better understand how the composer shelling out works and possibly sync with @jurre for a second opinion. |
We rely on some PHP code that uses Composer as a library for most things today (in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into this more, and they have a new audit
command that's enabled by default for composer update
(but not composer install
). This command always does an API call to Packagist to check for security vulnerabilities for each package. We probably want to disable this by default, so I'm blocking this PR for now to ensure no one accidentally merges it w/o looking into this in more detail.
I also created a dedicated issue for it:
A newer version of composer/composer exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@dependabot recreate |
Superseded by #6385. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
e835fc8
to
fdea14f
Compare
Bumps [composer/composer](https://github.com/composer/composer) from 2.3.9 to 2.4.1. - [Release notes](https://github.com/composer/composer/releases) - [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md) - [Commits](composer/composer@2.3.9...2.4.1) --- updated-dependencies: - dependency-name: composer/composer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
fdea14f
to
e952560
Compare
Bumps composer/composer from 2.3.9 to 2.4.1.
Release notes
Sourced from composer/composer's releases.
... (truncated)
Changelog
Sourced from composer/composer's changelog.
Commits
777d542
Release 2.4.17ec6d16
Update changelogceb8bef
Adding hint what "Direct dependencies" means (#11013)d2d8474
Do not apply non-array package links in ArrayLoader (#11008)5177469
Do not apply non-string package link constraints in ArrayLoader (#11009)7ccf230
Fix cache invalidation issue when a git tag gets created on an old ref after ...cad5dc5
Match default choice to actual default (#11010)20b3e3e
Fix docs for issue composer/satis#656 (#11005)6b31fbe
Update pull_request_template.mdc529087
performance: Do not create a local cache repo for local repos (#11001)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)