Skip classifier when checking for internal dep #4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building up the list of internal dependencies, it is not possible to know the classifiers, so we skip appending classifier to a dependency name when checking whether it is an internal dependency or not.
|
cc @a1flecke |
feelepxyz
reviewed
Aug 4, 2021
| <groupId>net.evenh.multimodule</groupId> | ||
| <artifactId>util</artifactId> | ||
| <version>${project.version}</version> | ||
| <classifier>sources</classifier> |
There was a problem hiding this comment.
Could you add a test case in the filer_parser spec covering this case? Does this change mean we correctly detect internal dependencies?
There was a problem hiding this comment.
There is already a test case for this. Adding this classified dependency should cover the change. And yes, without the patch this added dependency will fail a test case where it asserts all dependencies to look for updates.
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh gotcha! Thanks for linking 👍
feelepxyz
approved these changes
Aug 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building up the list of internal dependencies, it is not possible
to know the classifiers, so we skip appending classifier to a dependency
name when checking whether it is an internal dependency or not.
The details of this proposed change is described by https://github.com/dependabot/dependabot-core/pull/1924#issuecomment-891981747https://github.com/dependabot/dependabot-core/pull/1924#issuecomment-891981747