Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure] Add retries for Azure client POST #3843

Merged
merged 2 commits into from
Jun 8, 2021
Merged

[Azure] Add retries for Azure client POST #3843

merged 2 commits into from
Jun 8, 2021

Conversation

AlekhyaYalla
Copy link
Contributor

@AlekhyaYalla AlekhyaYalla commented Jun 3, 2021 •
edited
Loading

Azure client today doesn't implement any retries for POST requests. Azure GET has retry functionality for ServiceUnavailable errors. When working with bigger repos, we see (transient) ServiceUnavailable more often for POST requests. This PR adds retries for the standard 500, 502, and 503 errors.

@AlekhyaYalla AlekhyaYalla requested a review from a team as a code owner June 3, 2021 09:49
jurre
jurre approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for this 👍

@AlekhyaYalla
Copy link
Contributor Author

Makes sense, thanks for this 👍

@AlekhyaYalla AlekhyaYalla reopened this Jun 3, 2021
@AlekhyaYalla AlekhyaYalla force-pushed the alekhyayalla/retry_azure_post_request branch from 54ed8c7 to 3124be2 Compare June 3, 2021 17:57
@AlekhyaYalla
Copy link
Contributor Author

AlekhyaYalla commented Jun 4, 2021 •
edited
Loading

Hi @jurre @brrygrdn @xlgmokha Can you help review this? Thanks! ,I have pushed another commit. Not sure why all the checks are in pending for a long time. Could you please approve the workflows to trigger the checks?

@milind009
Copy link
Contributor

Hi @jurre @brrygrdn @xlgmokha Can you help review this? Thanks! ,I have pushed another commit. Not sure why all the checks are in pending for a long time. Could you please approve the workflows to trigger the checks?

Tagging @feelepxyz for visibility

@feelepxyz feelepxyz enabled auto-merge June 7, 2021 11:23
@AlekhyaYalla
Copy link
Contributor Author

Failure in running Nuget tests step. It seems like some other issue, as our code changes will not affect any of the NuGet tests.
@feelepxyz @jurre @brrygrdn @xlgmokha

@AlekhyaYalla AlekhyaYalla requested a review from jurre June 8, 2021 04:15
@jurre
Copy link
Member

jurre commented Jun 8, 2021

@AlekhyaYalla a rebase should fix the failing test

auto-merge was automatically disabled June 8, 2021 06:54

Head branch was pushed to by a user without write access

@AlekhyaYalla AlekhyaYalla force-pushed the alekhyayalla/retry_azure_post_request branch from 3124be2 to 90adeb8 Compare June 8, 2021 06:54
@AlekhyaYalla
Copy link
Contributor Author

AlekhyaYalla commented Jun 8, 2021 •
edited
Loading

Rebased this branch alekhyayalla/retry_azure_post_request with dependabot-core main branch. @jurre Could you help to approve this?

@jurre jurre merged commit f5d81dc into dependabot:main Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurre jurre Awaiting requested review from jurre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekhyaYalla @milind009 @jurre